perf: impl put_many and reuse column families #412
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rklaehn
force-pushed
the
rklaehn/bulk-put
branch
from
6f18ec3 to
a47d4ba
Compare
rklaehn
force-pushed
the
rklaehn/bulk-put
branch
from
03a8fe1 to
330e7b6
Compare
|
|
||
| #[tracing::instrument(skip(self))] | ||
| pub async fn get(&self, cid: &Cid) -> Result<Option<DBPinnableSlice<'_>>> { | ||
| self.get0(cid, &self.cfs()?) |
There was a problem hiding this comment.
what about using `spawn_blocking?
There was a problem hiding this comment.
Yes, I noticed this as well now that I removed all the async. It was not using spawn_blocking before, but it probably should.
But I got a branch where I really clean things up, so I would prefer to introduce spawn_blocking there. https://github.com/n0-computer/iroh/tree/rklaehn/local-gb
This requires getting rid of a lot of async in the store. Async only in the public interface
rklaehn
force-pushed
the
rklaehn/bulk-put
branch
from
90bba13 to
a193ab4
Compare
|
This branch: Main: |
dignifiedquire
approved these changes
Oct 25, 2022
|
@rklaehn did you switch up things? or does this make things slower? |
Merged
If Im reading the above correct, it's 1 sec faster but uses more CPU cores (hence user time higher) |
b5
approved these changes
Oct 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This requires getting rid of a lot of async in the store. Async only in the public interface.
I want to do some more reorg here, but in the interest of getting something on main soon I will refrain from it...